 OM4
Post count: 13
|
During the MasterPress install process, I’m getting the following errors:
Non-static method MPU::combine_type_styles() should not be called statically
Non-static method MPU::combine_type_scripts() should not be called statically
Error Number 2048 (E_STRICT)
Line 3467/3468 in masterpress.php.
|
|
OM4
Post count: 13
|
Another issue I noticed during the install/upgrade process, because your table definitions in MasterPress::install() use boolean column definitions, dbDelta() executes unnecessary ALTER statements:
http://pastebin.com/FfBhJyNw
Instead of using boolean, it is better to use tinyint(1). See http://core.trac.wordpress.org/ticket/20634 for details.
|
 traversal
Post count: 207
|
Sorry about those issues, I’ll take a look ASAP. Thanks heaps for the tip about tinyint as well. dbDelta is a bit painful to work with in general, with its sometimes-bizarre syntax requirements.
-
This reply was modified 10 years, 9 months ago by
 traversal.
|
|
OM4
Post count: 13
|
No worries Trav.
dbDelta() is definitely pretty picky about it’s SQL format!
|
|
OM4
Post count: 13
|
Hi Trav, is there any chance these issues could be fixed before 1.0.1 final is released?
They’re relatively minor syntax errors, and I’ve just looked at beta 7 and these issues still exist.
Thanks.
|
|
traversal
Post count: 207
|
Yep, will do.
|
|
traversal
Post count: 207
|
These two issues are now fixed in 1.0.1.b8. Thanks again for the bug reports 🙂
|
.